Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid elements created through the create element ns api from escaping the sandbox #645

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

zhoushaw
Copy link
Member

Description

  • Avoid escaping the sandbox when an element created through the create Element ns api gets the owner document
  • Added the owner document configuration

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
garfish ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 0:11am

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


zhouxiao.shaw seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3116431) 83.28% compared to head (0ddadf7) 83.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
+ Coverage   83.28%   83.31%   +0.02%     
==========================================
  Files          90       90              
  Lines       12482    12492      +10     
  Branches     1933     1931       -2     
==========================================
+ Hits        10396    10408      +12     
  Misses       2069     2069              
+ Partials       17       15       -2     
Files Coverage Δ
packages/browser-vm/src/dynamicNode/index.ts 92.81% <100.00%> (+0.04%) ⬆️
packages/browser-vm/src/pluginify.ts 86.80% <100.00%> (+0.13%) ⬆️
...ckages/browser-vm/src/proxyInterceptor/document.ts 81.54% <100.00%> (+1.91%) ⬆️
packages/core/src/config.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nyqykk nyqykk added this pull request to the merge queue Oct 19, 2023
Merged via the queue into main with commit be01235 Oct 19, 2023
7 of 9 checks passed
@nyqykk nyqykk deleted the fix/add-fixOwnerDocument-config branch October 19, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants