Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sandbox): fix the XMLHttpRequest object memory leak #642

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

danpeen
Copy link
Collaborator

@danpeen danpeen commented Sep 26, 2023

Description

fix(sandbox): fix the XMLHttpRequest object memory leak.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
garfish ✅ Ready (Inspect) Visit Preview Sep 26, 2023 10:51am

@danpeen danpeen changed the title fix(sandbox): fix the XMLHttpRequest object memory leaks problem fix(sandbox): fix the XMLHttpRequest object memory leak Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (9bc85ec) 83.34% compared to head (22f51e7) 83.28%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #642      +/-   ##
==========================================
- Coverage   83.34%   83.28%   -0.06%     
==========================================
  Files          90       90              
  Lines       12461    12482      +21     
  Branches     1932     1933       +1     
==========================================
+ Hits        10385    10396      +11     
- Misses       2059     2069      +10     
  Partials       17       17              
Files Coverage Δ
...ackages/browser-vm/src/modules/mutationObserver.ts 100.00% <100.00%> (ø)
packages/browser-vm/src/pluginify.ts 86.66% <100.00%> (+0.06%) ⬆️
packages/browser-vm/src/sandbox.ts 91.95% <100.00%> (+0.02%) ⬆️
packages/browser-vm/src/modules/network.ts 80.32% <70.00%> (-0.87%) ⬇️
packages/browser-vm/src/modules/timer.ts 76.25% <63.63%> (-1.84%) ⬇️
packages/browser-vm/src/modules/eventListener.ts 46.15% <0.00%> (-3.17%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhoushaw zhoushaw merged commit 44908db into main Oct 9, 2023
6 of 9 checks passed
@zhoushaw zhoushaw deleted the fix/xhr-memory-leaks branch October 9, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants