Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es-module): fix bug when export * from 'xx' #635

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

imtaotao
Copy link
Collaborator

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
garfish ✅ Ready (Inspect) Visit Preview Jul 20, 2023 7:23am

@CLAassistant
Copy link

CLAassistant commented Jul 20, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (25f93fd) 83.30% compared to head (36aeed4) 83.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
+ Coverage   83.30%   83.33%   +0.02%     
==========================================
  Files          90       90              
  Lines       12456    12460       +4     
  Branches     1933     1932       -1     
==========================================
+ Hits        10377    10384       +7     
+ Misses       2061     2059       -2     
+ Partials       18       17       -1     
Impacted Files Coverage Δ
packages/es-module/src/compiler/index.ts 99.18% <100.00%> (+<0.01%) ⬆️
packages/es-module/src/runtime.ts 93.56% <100.00%> (+0.46%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@imtaotao imtaotao requested a review from lideming July 21, 2023 03:34
@imtaotao imtaotao added this pull request to the merge queue Jul 21, 2023
Merged via the queue into main with commit 695df5e Jul 21, 2023
6 checks passed
@imtaotao imtaotao deleted the fix/esmodule-bug branch July 21, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants