improve logic for no lemon squeezy customer portal url #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincanger
commented
Sep 12, 2024
| @@ -39,7 +38,7 @@ export const generateCheckoutSession: GenerateCheckoutSession<PaymentPlanId, Che | |||
| }; | |||
| }; | |||
|
|
|||
| export const getCustomerPortalUrl: GetCustomerPortalUrl<void, string | undefined> = async (_args, context) => { | |||
| export const getCustomerPortalUrl: GetCustomerPortalUrl<void, string | null> = async (_args, context) => { | |||
There was a problem hiding this comment.
I changed this to null since that's what prisma returns if the user hasn't had a customer portal url assigned to it yet by Lemon Squeezy
Martinsos
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we had a user confused by the current console.log statement
User with ID 123... does not have a LemonSqueezy customer portal URLso I removed the log and added a note to the file. I also changed a bit of the logic.