Replace favicon #267
Replace favicon #267
Conversation
There was a problem hiding this comment.
Hey, it seems you accidentally committed Mac OS's .DS_Store directories.
That directory should probably be listed in the top-level .gitignore file.
It's strange that this doesn't happen more often since more than half the team is on a Mac.
@infomiho Correct me if I'm missing something and you Mac guys deal with these directories differently.
If not, @mmaksimovic please add .DS_Store to .gitignore and remove them from this PR (enough to delete those folders, git add ., git commit, git push).
|
@sodic Fixed! Looks like we have some flaky tests, the last commit I made was empty, and the tests passed 😅 |
No worries, that's perfectly fine. If tests are passing before an empty commit, they should be passing on the empty commit too (since it didn't change anything). What's strange is that one of the tests failed in the first place, but it seems to have been a network issue. I'll look into it right away. Btw, there's still one |
|
ahhh, my bad, done! |
| @@ -1,2 +1,3 @@ | |||
| /template/app/migrations | |||
| /template/app/package-lock.json | |||
| .DS_Store | |||
There was a problem hiding this comment.
Looks good 👍 we have the same in the Wasp compiler .gitignore
Description
Instead of using Wasp's logo as a favicon, use a free bee icon template.