add output cypher component #118
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jem Davies <jemsot@gmail.com>
gregfurman
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Think this should be removed
Comment on lines
+19
to
+21
| service.NewBoolField("noAuth"). | ||
| Description("No Authentication currently implemented, defaults to true."). | ||
| Default(true), |
There was a problem hiding this comment.
Maybe this should be removed for now since it doesn't look like it's being used?
| values[k] = v.String(msgPart) | ||
| } | ||
|
|
||
| _, err := neo4j.ExecuteQuery(ctx, cyp.driver, |
There was a problem hiding this comment.
Should this output be a query or an INSERT statement of some kind? I'd imagine aSELECT (or neo4j equivalent) shouldn't be processed as output
| if err != nil { | ||
| return nil, err | ||
| } | ||
| query, err := conf.FieldString("query") |
There was a problem hiding this comment.
Just a thought but I wonder if this should be sanitised in some way to prevent some query injection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.