Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix save_as_jpeg failing on rgba images #62

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix save_as_jpeg failing on rgba images #62

wants to merge 1 commit into from

Conversation

temaput
Copy link

@temaput temaput commented Jan 17, 2018

as it states here python-pillow/Pillow#2609 we now need to explicitly convert rgba to rgb before converting to jpg

@kaedroho
Copy link
Contributor

kaedroho commented Apr 3, 2018 •
edited
Loading

Thanks for looking into this! But you can't just convert an RGBA to RGB though as this tends to screw up images that have transparency.

Instead, we should use the set_background_color_rgb operation to convert the image and set the background colour to black.

@dopry
Copy link
Contributor

dopry commented Oct 19, 2022

@temaput would you have time to address the changes @kaedroho requested? @kaedroho is there an underlying bug here that should be addressed? Maybe this should be moved to an issue if there is a demonstrable bug with saving to discuss a solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@temaput @kaedroho @dopry