Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite #11 #12

Closed
wants to merge 24 commits into from
Closed

Rewrite #11 #12

wants to merge 24 commits into from

Conversation

vyshnav-vinod
Copy link
Owner

This PR will consist of the rewrite branch of getodo.

Will be kept open until the rewrite is complete

@vyshnav-vinod vyshnav-vinod linked an issue Apr 24, 2024 that may be closed by this pull request
@vyshnav-vinod
Copy link
Owner Author

#10 should be fixed by now

@vyshnav-vinod vyshnav-vinod marked this pull request as draft April 24, 2024 09:28
@vyshnav-vinod vyshnav-vinod added enhancement New feature or request help wanted Extra attention is needed labels Apr 24, 2024
@vyshnav-vinod vyshnav-vinod added this to the v2.0.0 milestone Apr 24, 2024
@vyshnav-vinod vyshnav-vinod self-assigned this Apr 24, 2024
@vyshnav-vinod
Copy link
Owner Author

0900f4d moves utility functions to utils.py

Add requirements.txt as well
@vyshnav-vinod
Copy link
Owner Author

Added utils function to add output to gitignore (Assumes gitignore is in the root dir of the parse_path

@vyshnav-vinod
Copy link
Owner Author

TodoParser test added. Now need to add utils test

@vyshnav-vinod
Copy link
Owner Author

Added a test for get_comment_syntax (The other utils functions did not really needed a test)

@vyshnav-vinod
Copy link
Owner Author

39011aa

@vyshnav-vinod
Copy link
Owner Author

Thinking about removing the -c/--config flag...
Maybe rewrite will be done when the remaining two flags are implemented

@vyshnav-vinod
Copy link
Owner Author

I guess -a/--add_filetypes flag is not needed as well? Dont need to complicate this too much. If there are still unsupported filetypes, we can ask users to start a issue or a PR if needed.

@vyshnav-vinod
Copy link
Owner Author

I messed up the -i flag and deleted everything i did on that flag. Going to take a break to get my mind cleared. Maybe back after 2 days.

@vyshnav-vinod
Copy link
Owner Author

-i/--ignore has been implemented.. Tests only remains.. after that rewrite will be merged and then deployment stuff will be added in the main branch

@vyshnav-vinod
Copy link
Owner Author

Everything except the deployment is done.. Only the README is left

@vyshnav-vinod vyshnav-vinod marked this pull request as ready for review April 30, 2024 16:42
@vyshnav-vinod
Copy link
Owner Author

Closing and reopening to test workflow

@vyshnav-vinod vyshnav-vinod deleted the rewrite branch April 30, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete Rewrite
1 participant