Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EL 9 support #403

Merged
merged 2 commits into from
May 7, 2024
Merged

Add EL 9 support #403

merged 2 commits into from
May 7, 2024

Conversation

kenyon
Copy link
Member

@kenyon kenyon commented Dec 18, 2023

Suse support was dropped from metadata.json in voxpupuli#292 commit
77ea67b due to lack of working tests.
This also adjusts hiera.yaml to reduce the amount of data that need to
be duplicated. This hiera.yaml is now effectively the same as the
hiera.yaml used by default with PDK: https://github.com/puppetlabs/pdk-templates/blob/main/moduleroot_init/hiera.yaml.erb
@kenyon kenyon added the enhancement New feature or request label Dec 18, 2023
@kenyon kenyon mentioned this pull request Dec 18, 2023
@kenyon kenyon changed the title Add CentOS 9 support Add EL 9 support Dec 18, 2023
@h0tw1r3
Copy link
Contributor

h0tw1r3 commented Dec 18, 2023

Would it make sense to change hiera to search the os.family instead of (or in addition to) os.name?
centos 9, alma 9, rocky 9, rhel 9 all have the same python version (and likely always will in the same family).

@kenyon
Copy link
Member Author

kenyon commented Dec 19, 2023

Would it make sense to change hiera to search the os.family instead of (or in addition to) os.name? centos 9, alma 9, rocky 9, rhel 9 all have the same python version (and likely always will in the same family).

Like I mentioned in #401 (review), I think it makes the most sense to eliminate the need to specify Python version in this module. But improving hiera.yaml is probably also a good idea.

@h0tw1r3
Copy link
Contributor

h0tw1r3 commented Dec 19, 2023

Like I mentioned in #401 (review), I think it makes the most sense to eliminate the need to specify Python version in this module. But improving hiera.yaml is probably also a good idea.

That's not possible as the python module specifies "3" as the default, el-8's all ship with python 3.6, but puppetboard required python 3.8 - 3.11.

@kenyon
Copy link
Member Author

kenyon commented Dec 19, 2023

Like I mentioned in #401 (review), I think it makes the most sense to eliminate the need to specify Python version in this module. But improving hiera.yaml is probably also a good idea.

That's not possible as the python module specifies "3" as the default, el-8's all ship with python 3.6, but puppetboard required python 3.8 - 3.11.

Yeah, I didn't look into the implementation details yet, but it doesn't make sense that every module using python should have to define the OS's default python version, right?

@h0tw1r3
Copy link
Contributor

h0tw1r3 commented Dec 19, 2023

Yeah, I didn't look into the implementation details yet, but it doesn't make sense that every module using python should have to define the OS's default python version, right?

Unfortunately, it does as python code/applications (virtualenv's) have different python interpreter requirements... which is definitely out of the sysadmins control.

The underlying problem, as I see it, is that the puppet python module only supports managing a single version of python. So if you must support different versions, you can't do it in a consistent way with puppet.

@kenyon
Copy link
Member Author

kenyon commented Dec 19, 2023

Yeah, I didn't look into the implementation details yet, but it doesn't make sense that every module using python should have to define the OS's default python version, right?

Unfortunately, it does as python code/applications (virtualenv's) have different python interpreter requirements... which is definitely out of the sysadmins control.

The underlying problem, as I see it, is that the puppet python module only supports managing a single version of python. So if you must support different versions, you can't do it in a consistent way with puppet.

I am just saying that the data about which version is the OS default should be centralized, so that other modules can look it up. That doesn't prevent overriding the default.

@kenyon
Copy link
Member Author

kenyon commented Jan 8, 2024

Same comment as #388 (comment)

@kenyon
Copy link
Member Author

kenyon commented Apr 17, 2024

Acceptance tests are hanging trying to install puppetlabs/puppetdb because we don't have a Forge release that supports stdlib 9. puppetlabs/puppetlabs-puppetdb#381 😡

@kenyon kenyon merged commit 22ed17c into voxpupuli:master May 7, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants