Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow puppet/python 4.x / use puppet/epel instead of stahnma-epel #280

Closed
wants to merge 3 commits into from

Conversation

bastelfreak
Copy link
Member

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak bastelfreak added the enhancement New feature or request label Apr 26, 2020
Copy link
Member

@dhoppe dhoppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to change the dependency at .fixtures.yaml.

@bastelfreak bastelfreak changed the title allow puppet/python 4.x allow puppet/python 4.x / Was1NicerDude Apr 26, 2020
@bastelfreak bastelfreak changed the title allow puppet/python 4.x / Was1NicerDude allow puppet/python 4.x / use puppet/epel instead of stahnma-epel Apr 26, 2020
@bastelfreak
Copy link
Member Author

I restared the one failed travis job

@pjonesIDBS
Copy link
Contributor

Pleased to see this is a WIP!

I've updated my local dev Puppet Master clone of puppet-puppetboard so the metadata permits puppet/python < 5.0.0 and all works nicely.

When do you think a release will be available supporting puppet/python > 4.x?

In terms of the README.md file the section for Python 3.x on RHEL / CentOS 7 it needs some work. The config there didn't work at all an even includes incorrect parameters for the puppetboard class.

Due to issues with the RH software collections versions of apache etc being a pain to manage, it was much easier to install the IUS repo version of python360-mod_wsgi. This works seamlessly with the standard httpd package. Very few changes were required to my existing manifest.

I can create an issue in the project if you're interested in seeing / documenting my config for Apache + Python 3 support.

@bastelfreak
Copy link
Member Author

@pjonesIDBS thanks for the comment. because of the failing tests I cannot merge this at the moment. Can you provide a PR that updates the README.md?

pjonesIDBS added a commit to pjonesIDBS/puppet-puppetboard that referenced this pull request May 28, 2020
As per voxpupuli#280 here are some alternative instructions for CentOS 7 and RHEL 7 users to utlilse Python 3 with Apache (httpd).
@pjonesIDBS
Copy link
Contributor

I've created #285 with some alterantive guidance in the README.md. Apologies for not getting to this sooner.

@vox-pupuli-tasks
Copy link

Dear @bastelfreak, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@bastelfreak bastelfreak added skip-changelog and removed enhancement New feature or request tests-fail labels Oct 5, 2020
@bastelfreak
Copy link
Member Author

those changes are now in our master branch :)

@bastelfreak bastelfreak closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants