Release 10.0.0 #479
Release 10.0.0 #479
Conversation
|
|
||
| [Full Changelog](https://github.com/voxpupuli/puppet-nodejs/compare/v9.0.1...v9.1.0) | ||
|
|
||
| **Breaking changes:** | ||
|
|
||
| - Drop Puppet 6 support [\#467](https://github.com/voxpupuli/puppet-nodejs/pull/467) ([bastelfreak](https://github.com/bastelfreak)) |
There was a problem hiding this comment.
Should we yank the 9.1.0 release because of that?
There was a problem hiding this comment.
in my opinion this is basically a breaking change und should require a major release. but maybe there are some other opinions (puppet6 is EOL so...)
There was a problem hiding this comment.
That's also my reasoning here.
Ideally we would yank that release from Forge and tell GHC to fold the changelog into the 10.0 one, but I have no idea how.
There was a problem hiding this comment.
GHC has a exclude-tags option, but I don't seem to be able to get it to work 😢
There was a problem hiding this comment.
on the other hand: whats done is done, yanking it now after the fact may create even more problems for others. i vote for just leaving it the way it is now
|
Could also wait for #480 :) |
Seems like a good idea, shouldnt take too long to get that one merged |
So I thought, but then we don't have Debian 12 support in puppet_metadata yet and Ubuntu 22.04 tests seem to timeout for some funny reason I couldn't care about right now. |
|
then lets leave it out for now, we could throw that in a 10.1.0 release if necessary |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues