move toml dependency to avoid toml missing when not needing ldap feature #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Sep 4, 2024
| @@ -156,6 +155,7 @@ def generate | |||
| end | |||
|
|
|||
| def eval_generate | |||
| require 'toml' | |||
There was a problem hiding this comment.
@joshcooper do you know if it's a good idea to move the require for an external gem into the eval_generate method?
There was a problem hiding this comment.
@bastelfreak that should be fine, as long as that's the first code path that attempt use use toml. Alternatively, if you implement the pre_run_check lifecycle method then you could require it there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This pull request tries to address installing the module in a restricted environment (no gem install available for toml) without failing as the LDAP feature is not needed in my scenario.
This Pull Request (PR) fixes the following issues
Fixes #338