Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modbus plugin #994

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add modbus plugin #994

wants to merge 2 commits into from

Conversation

ruleant
Copy link

@ruleant ruleant commented Jan 26, 2022

Pull Request (PR) description

This PR implements a modbus plugin for collectd.
It allows to specify hosts and data sets.

@ruleant ruleant force-pushed the modbus branch 3 times, most recently from e0df3f1 to 3411ed0 Compare January 26, 2022 14:41
This commit implements a modbus plugin.
It installs required packages and generates configuration for hosts and
datasets.
Copy link
Contributor

@traylenator traylenator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could rebase then you will profit from the fact that Arch support has been removed
and the failing test will no longer exist.

Adding a needs-rebase, be sure to remove once done.

@@ -0,0 +1,42 @@
<% if @data or @hosts -%>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If adding a new template could it be written in EPP?

@@ -0,0 +1,2 @@
#
type Collectd::Modbus::Data = Struct[{Optional['instance'] => String, NotUndef['type'] => String[1], NotUndef['register_base'] => Numeric, NotUndef['register_type'] => String[1]}]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some tests for this and the other types.

e.g. like https://github.com/voxpupuli/puppet-systemd/tree/master/spec/type_aliases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants