Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few PHP 8 related issues #42

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Fix a few PHP 8 related issues #42

merged 1 commit into from
Feb 15, 2024

Conversation

MelechMizrachi
Copy link
Collaborator

@MelechMizrachi MelechMizrachi commented Feb 15, 2024

SelectProcessor.php expected the return value of Evaluator to be an array for the case where the expression is a SubqueryExpression, but Evaluator already ensures the value returned is the value of the column requested. Also removing assertion as it does nothing in a production environment and might be mistaken as a stopper to run the code.
BinaryOperatorEvaluator.php would blindly try to divide any right/left value by the other without checking for 0 first.

@MelechMizrachi MelechMizrachi merged commit f845214 into master Feb 15, 2024
2 checks passed
@MelechMizrachi MelechMizrachi deleted the fix-php-8-issues branch February 15, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants