Merge pull request #14 from pros-rs/snafu-core-error

feat: use snafu error implementations
vexide · Dec 24, 2023 · 672e5d2 · 672e5d2
2 parents a43f1b4 + ac035fc
commit 672e5d2
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 6 deletions.
diff --git a/pros/Cargo.toml b/pros/Cargo.toml
@@ -17,6 +17,7 @@ spin = "0.9.8"
 pros-sys = { version = "0.4", path = "../pros-sys", features = ["xapi"] }
 snafu = { version = "0.7.5", default-features = false, features = [
     "rust_1_61",
+    "unstable-core-error",
 ] }
 no_std_io = { version = "0.6.0", features = ["alloc"] }
 futures = { version = "0.3.28", default-features = false, features = ["alloc"] }

diff --git a/pros/src/error.rs b/pros/src/error.rs
@@ -90,7 +90,6 @@ pub enum PortError {
     ))]
     PortCannotBeConfigured,
 }
-impl core::error::Error for PortError {}
 
 map_errno!(PortError {
     ENXIO => Self::PortOutOfRange,

diff --git a/pros/src/lcd/mod.rs b/pros/src/lcd/mod.rs
@@ -37,4 +37,3 @@ pub enum LcdError {
     #[snafu(display("LCD not initialized"))]
     NotInitialized,
 }
-impl core::error::Error for LcdError {}
diff --git a/pros/src/link.rs b/pros/src/link.rs
@@ -178,7 +178,6 @@ pub enum LinkError {
     #[snafu(display("{source}"), context(false))]
     Port { source: PortError },
 }
-impl core::error::Error for LinkError {}
 
 map_errno! {
     LinkError {

diff --git a/pros/src/motor.rs b/pros/src/motor.rs
@@ -305,7 +305,6 @@ pub enum MotorError {
     #[snafu(display("{source}"), context(false))]
     Port { source: PortError },
 }
-impl core::error::Error for MotorError {}
 
 map_errno! {
     MotorError {}

diff --git a/pros/src/sensors/gps.rs b/pros/src/sensors/gps.rs
@@ -80,7 +80,6 @@ pub enum GpsError {
     #[snafu(display("{source}"), context(false))]
     Port { source: PortError },
 }
-impl core::error::Error for GpsError {}
 
 map_errno! {
     GpsError {

diff --git a/pros/src/sensors/vision.rs b/pros/src/sensors/vision.rs
@@ -221,7 +221,6 @@ pub enum VisionError {
     #[snafu(display("{source}"), context(false))]
     Port { source: PortError },
 }
-impl core::error::Error for VisionError {}
 
 map_errno! {
     VisionError {