[AP] Added AP Flow to VPR #2746
Conversation
This adds the AP flow to VPR, allowing AP to be called from the command line and how the input and output of the flow will interract with the rest of VPR.
github-actions
bot
added
VPR
| // some fixed blocks somewhere. Maybe we can live without fixed | ||
| // blocks. | ||
|
|
||
| // FIXME: Should we enforce that the size of the device is fixed? Or is |
There was a problem hiding this comment.
Device size isn't fixed in the constraints file; it's specified either in the arch file or can be specified on the command line.
| @@ -276,6 +279,12 @@ void SetupVPR(const t_options* Options, | |||
| PlacerOpts->doPlacement = STAGE_DO; | |||
| } | |||
|
|
|||
| if (Options->do_analytical_placement) { | |||
There was a problem hiding this comment.
Maybe comment why: analytical placement performs both packing & placement with an integrated algorithm.
| @@ -1324,6 +1324,11 @@ argparse::ArgumentParser create_arg_parser(const std::string& prog_name, t_optio | |||
| .action(argparse::Action::STORE_TRUE) | |||
| .default_value("off"); | |||
|
|
|||
| stage_grp.add_argument<bool, ParseOnOff>(args.do_analytical_placement, "--analytical_place") | |||
| .help("Run analytical placement") | |||
There was a problem hiding this comment.
I'd expand on this .help. Should say analytical placement uses an integrated packing & placement algorithm.
(Reason to explain this: otherwise it would make more sense for us to just have another set of placement options, but not a different stage).
| * True if analytical placement is supposed to be done in the CAD | ||
| * flow. False if otherwise. | ||
| */ | ||
| struct t_ap_opts { |
There was a problem hiding this comment.
I know we've got lots of types in this file already, but I wonder if the t_ap_ops should go in the analytical_place directory (maybe ap_types.h) instead? Don't worry about it if that would be a big refactor or be more trouble than it is worth due to being inconsistent with other opts.
This adds the AP flow to VPR, allowing AP to be called from the command line and how the input and output of the flow will interract with the rest of VPR.
Note: I was unable to add a testcase for this since VPR does not have the infrastructure in place to do an "expected fail" (from a full flow call like basic tests and strong tests). Eventually this may be a nice feature to have.