Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Trying to fix the failing unit test #2735

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

soheilshahrouz
Copy link
Contributor

I couldn't reproduce the unit test failure on a local machine, so I created this PR to trigger a CI run and hopefully locate the segault.

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code labels Sep 21, 2024
@AlexandreSinger
Copy link
Contributor

AlexandreSinger commented Sep 21, 2024

@soheilshahrouz A suggestion which might make things easier is to increase the assert level for the unit test for your test and turning on the sanitizer so you can try and catch the bug in action.

Locally you can try building with:
CMAKE_PARAMS="-DVTR_ASSERT_LEVEL=3 -DVTR_ENABLE_SANITIZE=ON"
I set the assert level to 3, but you can increase it to 4 if you really want. I think the sanitizer will be the most help. It will slow things down tremendously, but since this is a unit test it should be pretty quick.

Edit:
The CI just does not seem to be consistent; so building and running locally may be better.

My guess is that this testcase has a memory leak; and specifically how the binary is built may change when it crashes and how (which explains why it crashes in different ways each time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants