Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set value on named range to check sp.named_ranges for real address #243

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Fix set value on named range to check sp.named_ranges for real address #243

merged 2 commits into from
Jan 14, 2020

Conversation

conradbez
Copy link

  • Fix test for set value on named range and added a new test for consequential set_value() on named cells.

  • Changed set_value() to get real address for named cells from sp.named_ranges

First pull requests so let me know if you need anything else.

@conradbez
Copy link
Author

#242

@brianmay
Copy link
Collaborator

I believe the CI build failure on 2.7 should be fixed on latest master. Merging.

@brianmay brianmay merged commit 1b5fdba into vallettea:master Jan 14, 2020
@conradbez conradbez deleted the fix_test_after_set_value branch January 15, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants