Fix replica online timing issue in failover test #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ci reported this failure:
```
[exception]: Executing test client: ERR FAILOVER target replica is not online..
ERR FAILOVER target replica is not online.
while executing
"$node_0 failover to $node_1_host $node_1_port"
```
We can see somehow the replica is not online in time and
casuing this failure, added a verify_replica_online to make
sure the replica is online for the test.
Signed-off-by: Binbin <binloveplay1314@qq.com>
enjoy-binbin
commented
Sep 18, 2024
| @@ -33,6 +33,8 @@ start_server {overrides {save {}}} { | |||
| $node_2 replicaof $node_0_host $node_0_port | |||
| wait_for_sync $node_1 | |||
| wait_for_sync $node_2 | |||
| verify_replica_online $node_0 0 50 | |||
| verify_replica_online $node_0 1 50 | |||
There was a problem hiding this comment.
actually wait_replica_online (only wait for the replica 0) should work in this case, but it does not seem to hurt to wait for both
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1044 +/- ##
============================================
- Coverage 70.62% 70.61% -0.02%
============================================
Files 114 114
Lines 61672 61672
============================================
- Hits 43555 43548 -7
- Misses 18117 18124 +7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ci reported this failure:
We can see somehow the replica is not online in time and
casuing this failure, added a verify_replica_online to make
sure the replica is online for the test.