fix: change number formatting with comma as decimal separator #6655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DiegoCardoso
changed the title
vursen
reviewed
Sep 26, 2024
| @@ -280,6 +280,7 @@ protected DecimalFormat getDecimalFormat(Locale locale) { | |||
| DecimalFormat instance = (DecimalFormat) DecimalFormat | |||
| .getInstance(locale); | |||
| instance.setGroupingUsed(false); | |||
| instance.setMaximumFractionDigits(15); | |||
There was a problem hiding this comment.
If I understand correctly, this setting should match the number of fraction digits specified in EXCEL_FORMULA_BAR_DECIMAL_FORMAT. However, that format allows for 16 digits, not 15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the number formatting configuration for locales that use commas as decimal separators. Before, the fraction part of the numbers in such locales would allow only 3 digits. This change allows more digits in the fractional part.
Fixes #5731
Type of change