Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember input spans to give better hints in case of errors #33

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Remember input spans to give better hints in case of errors #33

merged 6 commits into from
Nov 16, 2023

Conversation

Kijewski
Copy link
Contributor

@Kijewski Kijewski commented Oct 2, 2023

Currently if you use a non-renderable item in a definition, the entire definition will flair up red. This PR make the parser remember the spans of the input token, so the generator can use them in the generated syntax tree.

@utkarshkukreti utkarshkukreti merged commit 82a608b into utkarshkukreti:master Nov 16, 2023
15 checks passed
@utkarshkukreti
Copy link
Owner

Thanks, improvements to error messages are always welcome! I'll make a minor version release shortly.

@utkarshkukreti
Copy link
Owner

0.14.0 has been published with this change.

@Kijewski Kijewski deleted the pr-spans branch November 20, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants