Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to nodenext module #410

Merged
merged 3 commits into from
Jun 2, 2022
Merged

Switch to nodenext module #410

merged 3 commits into from
Jun 2, 2022

Conversation

perrin4869
Copy link
Collaborator

Merging this will ensure we maintain compatibility with nodenext modules (for example, we don't forget to add .js extensions).
Unfortunately, this is currently blocked by auth0/jwt-decode#130, and maybe even by ts-node, so keeping it as a draft

@perrin4869 perrin4869 marked this pull request as ready for review June 2, 2022 04:02
@coveralls
Copy link

coveralls commented Jun 2, 2022

Coverage Status

Coverage remained the same at 98.904% when pulling e780b4c on feature/nodenext into 7f76aaf on master.

@perrin4869
Copy link
Collaborator Author

ok I managed to find a way to override the official typings temporarily at least
We can remove those if/when auth0/jwt-decode#130 is ever merged

Copy link
Collaborator

@phieronymus phieronymus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phieronymus phieronymus merged commit 2d7a306 into master Jun 2, 2022
@phieronymus phieronymus deleted the feature/nodenext branch June 2, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants