-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define 3 new SSM parameters to store health check endpoints #171
Conversation
@nikki-t : this is great, but I now have a doubt: in the syntax specification, should: where in our case ${component}="sps"? @galenatjpl can you please clarify? |
As for the Gitbook documentation, we list there the endpoints of unity-test-venue (at least for now), so no need to update. But one thing to do is to update the Git variables that are used in the smoke and integration tests: |
@LucaCinquini - Sounds good on the GitBook and I will wait for clarification on the Do you want to include the health check endpoints in the Git variables in addition to the regular endpoint URLs? And if so do should we do this programmatically or manually? |
We probably don't need to do that now. Those variables are there to parametrize the smoke tests, which are already configured to use the URLs in that form. |
@LucaCinquini @nikki-t per the question above, This is consistent with the guidance here: So the way Nikki had if screen-shotted above, looks good to me. |
@LucaCinquini @nikki-t, that being said, if you think that we should be including ${serviceArea} in the path somewhere (e.g. "sps"), then we can discuss more. I think that's not necessary though. |
Ok, thanks @galenatjpl |
Purpose
SSM Parameter names must start with:
/unity/${project}/${venue}/component/
SSM Parameter endpoint format
Proposed Changes
Issues
Testing
Deployed to
unity-venue-dev
and reviewed SSM Parameters. The following parameters were created:Reviewed the content of each new parameter and confirmed that SSM parameter string can be loaded into correctly formatted JSON:
Note: URLs are shortened for readability.