kconfig: kconfiglib.py: Backup files only #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _save_old() to return early if <filename> is not file (or symlink to a file). This is simplest alternative to avoid attempt to rename /dev/null (which could succeed). This also keeps fifos (perhaps nonexistent potential usage but this is nicer). If <filename> were directory or socket, after shutil.copyfile(), writing to the file (by caller, _write_config()), would fail. Co-authored-by: Marti Bolivar <marti.bolivar@nordicsemi.no> Signed-off-by: Tomi Ollila <tomi.ollila@iki.fi>
|
See PR with same content in zephyrproject-rtos/zephyr#31438 and related issue in zephyrproject-rtos/zephyr#31362 for reasoning |
|
Rather unfortunately, it appears the original author of Kconfiglib disappeared. The Zephyr project has been granted ownership of the PyPI package via PEP-541 request, and I'm going to do a release based on a new repository in the ➡️ Action required: @domo141 Are you able to re-open your pull request on the new repository? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _save_old() to return early if is not file (or symlink
to a file).
This is simplest alternative to avoid attempt to rename /dev/null
(which could succeed).
This also keeps fifos (perhaps nonexistent potential usage but
this is nicer).
If were directory or socket, after shutil.copyfile(),
writing to the file (by caller, _write_config()), would fail.
Co-authored-by: Marti Bolivar marti.bolivar@nordicsemi.no
Signed-off-by: Tomi Ollila tomi.ollila@iki.fi