Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new fields to sentry config #5537

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

cgsunkel
Copy link
Contributor

@cgsunkel cgsunkel commented Jul 11, 2024

Description of change

We've been asked to add two more fields to our Sentry setup

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.29%. Comparing base (0c208ce) to head (ade0670).

Additional details and impacted files
@@                Coverage Diff                 @@
##           govuk-paas-deploy    #5537   +/-   ##
==================================================
  Coverage              96.29%   96.29%           
==================================================
  Files                    959      959           
  Lines                  22659    22659           
  Branches                2035     2035           
==================================================
  Hits                   21819    21819           
  Misses                   687      687           
  Partials                 153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgsunkel cgsunkel merged commit c86a698 into govuk-paas-deploy Jul 11, 2024
4 checks passed
@cgsunkel cgsunkel deleted the chore/add-more-fields-to-sentry-config branch July 11, 2024 11:18
cgsunkel added a commit that referenced this pull request Jul 15, 2024
* Update codeowners

* Add sample rate to sentry (#5532)

* Add sample rate to sentry

* Add new action for govpaas branch

* Bump django from 4.2.11 to 4.2.14 (#5536)

Bumps [django](https://github.com/django/django) from 4.2.11 to 4.2.14.
- [Commits](django/django@4.2.11...4.2.14)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add new fields to sentry config (#5537)

* Remove migration actions (#5538)

* Update redis

* Update open search

* Update pingdom end point url

* Feature/dpm 174 data hub api investigate rq health check (#5266)

* Create Command for rq health check and include in docker-compose.yml configuration.

* DPM 199 Data Hub API logging (#5304)

* Change logging to ASIM formatter

* Update common_logging.py

* do not run collectstatic at run time on DBT Platform

* add build configuration for DBT Platform

* remove debug setup

* Migration/DPM 343 Data Hub API application settings (#5340)

* Change DATABASE_URL connection string to DATABASE_CREDENTIALS containing JSON structure.

* update database environment for build job

* Rename reserved environment variables (#5345)

* Debug: DBT Platform

* Debug: metadata hawk authentication

* Debug: DBT Patch

* Debug: test on sector filter

* Debug: Hawk

* Undo debugging

* Fix Flake8 Missing newline between import groups (#5457)

* TET 801 Stop Opensearch addess showing credentials (#5519)

* Stop showing open search credentials on connection error.
* Allow for setting of pool maxsize on open search connection.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Christopher <christopher.sunkel@digital.trade.gov.uk>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lawrence Goldstien <lawrence.goldstein@digital.trade.gov.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants