Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require uk recipient company before project can move to verify win stage #5461

Conversation

oliverjwroberts
Copy link
Contributor

@oliverjwroberts oliverjwroberts commented Jun 3, 2024

Description of change

Investment projects now require the uk_company field (which indicates the UK recipient company) to be populated before moving to the verify win stage. This PR adds the API part of that functionality.

Link to frontend PR

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@oliverjwroberts oliverjwroberts self-assigned this Jun 3, 2024
@oliverjwroberts oliverjwroberts force-pushed the feature/CLS2-794-set-recipient-company-as-required-before-verify-win-stage branch 2 times, most recently from 69878ee to 32215f9 Compare June 4, 2024 06:25
@oliverjwroberts oliverjwroberts marked this pull request as ready for review June 4, 2024 07:41
@oliverjwroberts oliverjwroberts requested a review from a team as a code owner June 4, 2024 07:41
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (b48c2a1) to head (aa3271e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5461      +/-   ##
==========================================
+ Coverage   96.38%   96.39%   +0.01%     
==========================================
  Files         951      951              
  Lines       22488    22489       +1     
  Branches     2021     2021              
==========================================
+ Hits        21674    21679       +5     
+ Misses        661      659       -2     
+ Partials      153      151       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliverjwroberts oliverjwroberts force-pushed the feature/CLS2-794-set-recipient-company-as-required-before-verify-win-stage branch from 32215f9 to 1a60fe9 Compare June 6, 2024 06:54
@oliverjwroberts oliverjwroberts force-pushed the feature/CLS2-794-set-recipient-company-as-required-before-verify-win-stage branch from 1a60fe9 to aa3271e Compare June 6, 2024 09:00
@oliverjwroberts oliverjwroberts merged commit 5bb9f9d into main Jun 6, 2024
2 checks passed
@oliverjwroberts oliverjwroberts deleted the feature/CLS2-794-set-recipient-company-as-required-before-verify-win-stage branch June 6, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants