-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Flake8 Missing newline between import groups #5457
Merged
marijnkampf
merged 1 commit into
migration-deploy
from
migration/fix-flake8-import-groups
Jun 3, 2024
Merged
Fix Flake8 Missing newline between import groups #5457
marijnkampf
merged 1 commit into
migration-deploy
from
migration/fix-flake8-import-groups
Jun 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## migration-deploy #5457 +/- ##
====================================================
+ Coverage 96.39% 96.44% +0.04%
====================================================
Files 943 947 +4
Lines 22405 22457 +52
Branches 2016 2019 +3
====================================================
+ Hits 21598 21659 +61
+ Misses 658 651 -7
+ Partials 149 147 -2 ☔ View full report in Codecov by Sentry. |
oliverjwroberts
approved these changes
Jun 3, 2024
p3dr0migue1
approved these changes
Jun 3, 2024
Richard-Pentecost
approved these changes
Jun 3, 2024
marijnkampf
added a commit
that referenced
this pull request
Jun 12, 2024
cgsunkel
pushed a commit
that referenced
this pull request
Jun 14, 2024
cgsunkel
pushed a commit
that referenced
this pull request
Jun 25, 2024
marijnkampf
added a commit
that referenced
this pull request
Jul 1, 2024
marijnkampf
added a commit
that referenced
this pull request
Jul 1, 2024
cgsunkel
pushed a commit
that referenced
this pull request
Jul 15, 2024
cgsunkel
added a commit
that referenced
this pull request
Jul 15, 2024
* Update codeowners * Add sample rate to sentry (#5532) * Add sample rate to sentry * Add new action for govpaas branch * Bump django from 4.2.11 to 4.2.14 (#5536) Bumps [django](https://github.com/django/django) from 4.2.11 to 4.2.14. - [Commits](django/django@4.2.11...4.2.14) --- updated-dependencies: - dependency-name: django dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add new fields to sentry config (#5537) * Remove migration actions (#5538) * Update redis * Update open search * Update pingdom end point url * Feature/dpm 174 data hub api investigate rq health check (#5266) * Create Command for rq health check and include in docker-compose.yml configuration. * DPM 199 Data Hub API logging (#5304) * Change logging to ASIM formatter * Update common_logging.py * do not run collectstatic at run time on DBT Platform * add build configuration for DBT Platform * remove debug setup * Migration/DPM 343 Data Hub API application settings (#5340) * Change DATABASE_URL connection string to DATABASE_CREDENTIALS containing JSON structure. * update database environment for build job * Rename reserved environment variables (#5345) * Debug: DBT Platform * Debug: metadata hawk authentication * Debug: DBT Patch * Debug: test on sector filter * Debug: Hawk * Undo debugging * Fix Flake8 Missing newline between import groups (#5457) * TET 801 Stop Opensearch addess showing credentials (#5519) * Stop showing open search credentials on connection error. * Allow for setting of pool maxsize on open search connection. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Christopher <christopher.sunkel@digital.trade.gov.uk> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lawrence Goldstien <lawrence.goldstein@digital.trade.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added missing newline between import groups
Checklist
Has this branch been rebased on top of the current
migration-deploy
branch?Is the CircleCI build passing?
General points
Other things to check
fixtures/test_data.yaml
is maintained when updating modelsSee docs/CONTRIBUTING.md for more guidelines.