Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legacy_id migration. #5448

Merged
merged 1 commit into from
May 30, 2024
Merged

Fix legacy_id migration. #5448

merged 1 commit into from
May 30, 2024

Conversation

elcct
Copy link
Contributor

@elcct elcct commented May 30, 2024

Description of change

The migration function was not recording the ids of legacy breakdown and win adviser records. This corrects it.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@elcct elcct requested a review from a team as a code owner May 30, 2024 12:44
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (1cb0a95) to head (6a3ae06).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5448   +/-   ##
=======================================
  Coverage   96.40%   96.41%           
=======================================
  Files         947      947           
  Lines       22451    22451           
  Branches     2018     2018           
=======================================
+ Hits        21644    21646    +2     
+ Misses        658      657    -1     
+ Partials      149      148    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elcct elcct merged commit 1d99d29 into main May 30, 2024
2 checks passed
@elcct elcct deleted the fix/export-wins-migration-10 branch May 30, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants