Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/rr 1417 implement agreed content changes in export wins django admin #5447

Conversation

ince-dbt
Copy link
Contributor

@ince-dbt ince-dbt commented May 30, 2024

Description of change

This PR implements the recent agreed content changes

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@ince-dbt ince-dbt requested a review from a team as a code owner May 30, 2024 08:34
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (6a3ae06) to head (fc9d98e).
Report is 1 commits behind head on main.

Current head fc9d98e differs from pull request most recent head b0f93b0

Please upload reports for the commit b0f93b0 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5447   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files         947      948    +1     
  Lines       22451    22457    +6     
  Branches     2018     2018           
=======================================
+ Hits        21646    21652    +6     
  Misses        657      657           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ince-dbt ince-dbt force-pushed the Fix/RR-1417-Implement-agreed-content-changes-in-Export-Wins-Django-Admin branch from 8a611bb to fc9d98e Compare May 30, 2024 12:52
@ince-dbt ince-dbt force-pushed the Fix/RR-1417-Implement-agreed-content-changes-in-Export-Wins-Django-Admin branch from fc9d98e to 7322234 Compare May 30, 2024 13:37
@ince-dbt ince-dbt merged commit 58c8140 into main May 30, 2024
2 checks passed
@ince-dbt ince-dbt deleted the Fix/RR-1417-Implement-agreed-content-changes-in-Export-Wins-Django-Admin branch May 30, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants