Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax boolean fields for Legacy export wins. #5406

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

elcct
Copy link
Contributor

@elcct elcct commented May 10, 2024

Description of change

This relaxes Boolean fields in customer response to accommodate legacy wins without customer response.
This also updates handling of other fields that can be missing in the source data.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@elcct elcct requested a review from a team as a code owner May 10, 2024 07:55
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (e1580b1) to head (8cbb476).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5406      +/-   ##
==========================================
- Coverage   96.40%   96.39%   -0.01%     
==========================================
  Files         938      939       +1     
  Lines       22328    22332       +4     
  Branches     2002     2003       +1     
==========================================
+ Hits        21526    21528       +2     
- Misses        654      655       +1     
- Partials      148      149       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elcct elcct merged commit 7fa160b into main May 10, 2024
2 checks passed
@elcct elcct deleted the fix/export-wins-migration-2 branch May 10, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants