Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added customer response base manager query filter to excludes soft deleted wins for auto resend #5397

Merged
merged 1 commit into from
May 7, 2024

Conversation

dredmonds
Copy link
Contributor

@dredmonds dredmonds commented May 3, 2024

Description of change

This quick fix to excludes soft deleted Export wins from customer response when sending an email notification.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (48be494) to head (078fe93).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5397      +/-   ##
==========================================
+ Coverage   96.38%   96.43%   +0.04%     
==========================================
  Files         931      931              
  Lines       22075    22075              
  Branches     1971     1971              
==========================================
+ Hits        21277    21287      +10     
+ Misses        653      645       -8     
+ Partials      145      143       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dredmonds dredmonds marked this pull request as ready for review May 3, 2024 11:37
@dredmonds dredmonds requested a review from a team as a code owner May 3, 2024 11:37
@dredmonds dredmonds force-pushed the fix/added-is-deleted-win-status-query-filter branch from e8a557e to 078fe93 Compare May 7, 2024 09:19
@dredmonds dredmonds merged commit 141dc4a into main May 7, 2024
2 checks passed
@dredmonds dredmonds deleted the fix/added-is-deleted-win-status-query-filter branch May 7, 2024 11:14
@dredmonds dredmonds changed the title Added customer response base manager query filter to excludes wins being soft deleted Added customer response base manager query filter to excludes soft deleted wins for auto resend May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants