Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Legacy win migration function. #5395

Merged
merged 1 commit into from
May 7, 2024

Conversation

elcct
Copy link
Contributor

@elcct elcct commented May 2, 2024

Description of change

This adds a function that will let us migrate the legacy Export wins.

The function will be run manually to assess the quality of migration and likely there will be more PRs coming with improvements.

The imported Legacy wins will not be visible to the users without a feature flag.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@elcct elcct requested a review from a team as a code owner May 2, 2024 08:36
Copy link
Contributor

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some food for thought. View full project report here.

datahub/export_win/export_wins_api.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

Attention: Patch coverage is 93.91304% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 96.35%. Comparing base (48be494) to head (de9d982).

❗ Current head de9d982 differs from pull request most recent head efd0080. Consider uploading reports for the commit efd0080 to get more accurate results

Files Patch % Lines
datahub/export_win/legacy_migration.py 92.09% 9 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5395      +/-   ##
==========================================
- Coverage   96.38%   96.35%   -0.03%     
==========================================
  Files         931      935       +4     
  Lines       22075    22300     +225     
  Branches     1971     2002      +31     
==========================================
+ Hits        21277    21488     +211     
- Misses        653      662       +9     
- Partials      145      150       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elcct elcct force-pushed the feature/export-wins-migration-mapping branch from de9d982 to efd0080 Compare May 7, 2024 08:29
@elcct elcct merged commit fa9d0a3 into main May 7, 2024
2 checks passed
@elcct elcct deleted the feature/export-wins-migration-mapping branch May 7, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants