Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt GVA formula to exclude FDI retention projects #5377

Conversation

oliverjwroberts
Copy link
Contributor

@oliverjwroberts oliverjwroberts commented Apr 22, 2024

Description of change

This PR modifies how Gross Value Added (GVA) is calculated for an investment project. Now, projects with an FDI type of retention will return a GVA multiplier of None, and thus, have no GVA.

See ticket CLS2-788 for more information.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@oliverjwroberts oliverjwroberts requested a review from a team as a code owner April 22, 2024 11:05
@oliverjwroberts oliverjwroberts self-assigned this Apr 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (96c5b07) to head (1150117).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5377   +/-   ##
=======================================
  Coverage   96.38%   96.39%           
=======================================
  Files         930      930           
  Lines       22065    22068    +3     
  Branches     1970     1971    +1     
=======================================
+ Hits        21267    21272    +5     
+ Misses        653      652    -1     
+ Partials      145      144    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliverjwroberts oliverjwroberts force-pushed the feature/CLS2-788-adapt-gva-formula-to-exclude-retention-projects branch from c125a7c to 1150117 Compare April 23, 2024 11:42
@oliverjwroberts oliverjwroberts merged commit 708fe6b into main Apr 23, 2024
2 checks passed
@oliverjwroberts oliverjwroberts deleted the feature/CLS2-788-adapt-gva-formula-to-exclude-retention-projects branch April 23, 2024 12:23
@oliverjwroberts oliverjwroberts changed the title Adapt GVA formular to exclude FDI retention projects Adapt GVA formula to exclude FDI retention projects May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants