Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/RR-1343-export-win-admin-user-access #5322

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

chopkinsmade
Copy link
Contributor

@chopkinsmade chopkinsmade commented Apr 2, 2024

Description of change

Add a new mixin to limit any adviser with the ExportWinAdmin group to only see the export_win module pages. Some models do not inherit from the BaseModelAdminMixin, so they have had the ExportWinsAdminMixin added to them directly

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.46%. Comparing base (faa254d) to head (889c6ca).

Files Patch % Lines
datahub/export_win/admin.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5322      +/-   ##
==========================================
- Coverage   96.47%   96.46%   -0.01%     
==========================================
  Files         925      925              
  Lines       21906    21927      +21     
  Branches     1961     1963       +2     
==========================================
+ Hits        21133    21152      +19     
- Misses        625      626       +1     
- Partials      148      149       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chopkinsmade chopkinsmade force-pushed the feature/RR-1343-export-win-admin-user-access branch from 0aabceb to 2880255 Compare April 3, 2024 09:54
@chopkinsmade chopkinsmade changed the title WIP: feature/RR-1343-export-win-admin-user-access feature/RR-1343-export-win-admin-user-access Apr 3, 2024
@chopkinsmade chopkinsmade removed the wip label Apr 3, 2024
@chopkinsmade chopkinsmade marked this pull request as ready for review April 3, 2024 10:46
@chopkinsmade chopkinsmade requested a review from a team as a code owner April 3, 2024 10:46
@chopkinsmade chopkinsmade merged commit 9a6f54f into main Apr 3, 2024
3 of 4 checks passed
@chopkinsmade chopkinsmade deleted the feature/RR-1343-export-win-admin-user-access branch April 3, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants