Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QueryWorkflow Route Handler #672

Open
wants to merge 6 commits into
base: release/4.0.0
Choose a base branch
from

Conversation

adhityamamallan
Copy link
Contributor

@adhityamamallan adhityamamallan commented Sep 19, 2024

Summary

API changes

  • Add route handler for QueryWorkflow

Queries loader changes

  • Remove suspense boundary from queries page, since the tabs already have it
  • Move useQueries logic + inputs state to a separate hook file for readability
  • Add generic types to useQueries

Queries tile changes

  • Create custom WorkflowQueryStatus, which adds the type 'fetching' to the regular QueryStatus
  • Disable run button when query status is 'fetching'

JSON viewer changes

  • Add useQueryJsonContent which looks at query state to decide what to show, and if it should be rendered as an error
  • Show spinner for loading state

Test plan

Unit tests + ran cadence-web locally.

Screenshot 2024-09-19 at 5 57 38 PM
Screenshot 2024-09-19 at 5 33 24 PM
Screenshot 2024-09-19 at 5 36 58 PM

@adhityamamallan adhityamamallan marked this pull request as ready for review September 19, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant