Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade base docker image, npm and node versions #653

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v2
with:
node-version: '14'
node-version: '16'
- run: npm ci
- run: npm run lint:check
- run: npm run test:unit
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:fermium-bullseye AS BUILD_IMAGE
FROM node:16.20.2-bookworm AS BUILD_IMAGE

### Build step ###
WORKDIR /usr/build
Expand All @@ -13,7 +13,7 @@ RUN npm install --no-save --production --unsafe-perm
RUN npm run build-production

# switch to lite version of node
FROM node:fermium-bullseye-slim
FROM node:16.20.2-bookworm-slim

### Run step ###
WORKDIR /usr/app
Expand Down
1 change: 1 addition & 0 deletions client/test/workflow.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -627,6 +627,7 @@ describe('Workflow', () => {
}

it('should build timeline events from granular event history', async function test() {
this.retries(3); // flakey on mocha-chrome but not normal, windowed Chrome
const [, compactViewEl] = await compactViewTest(this.test);

await retry(() =>
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ services:
base:
env_file:
- .docker_env
image: node:fermium-bullseye
image: node:16.20.2-bookworm
volumes:
- .:/usr/src/service
working_dir: /usr/src/service
Expand Down
Loading
Loading