Data race fix for context slog.Logger #1193
Open
+152
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See tus#1192 This adds a mock slog Logger to create a data race issue. Run go test -race to trigger
This fix adds two possible solutions to the data race issue. We either add the "id" info manually when logging, or we create a function-scoped logger based on the initial logger. The context logger must not be mutated.
wongak
changed the title
|
Thank you for looking into this! As mentioned in #1192 (comment), it's probably easier to set the |
|
@wongak I enabled the race detector for CI in this PR and reverted your fix (for now) in an attempt to reproduce this race warning. However, neither locally nor on CI is the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1192
This adds a mock slog Logger to create a data race issue. Run go test -race to trigger.
I am currently thinking about different approaches for a fix. But it's a bit complicated.
The way
httpContextis implemented does not allow any mutations. It would need to be cloned, and any requests would need to be copied as well withhttp.Request.WithContextto contain the httpContext.