Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-27 fix versioning tag build workflow #89

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

svenrademakers
Copy link
Collaborator

@svenrademakers svenrademakers commented Jul 3, 2023

fixes #27
Make sure to checkout the whole git history, so that git describe can do its work

Copy link
Contributor

@ruslashev ruslashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to mention that resulting filenames have short commit abbreviations in them (e.g. turingpi_v1.0.2-50-g9ce0573c.swu) but then I noticed that this is the intended behavior of git describe, so no issues here.

By the way, why do we retrieve buildroot's ccache?

@svenrademakers
Copy link
Collaborator Author

svenrademakers commented Jul 3, 2023

By the way, why do we retrieve buildroot's cache?

This is an attempt to speed up compilation by downloading ccache objects of a previous workflow run.
At the moment rerun's are the only scenario's we can see significant speedup's. We should experiment a bit more with keys etc to see how we get the best caching performance.

@svenrademakers svenrademakers merged commit ade8975 into master Jul 3, 2023
1 check passed
@svenrademakers svenrademakers deleted the feature/fix_version_tag branch July 3, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version build
2 participants