CI: build using docker image #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenrademakers
force-pushed
the
feature/docker_ci
branch
6 times, most recently
from
52a211b
to
1d5d631
Compare
By using docker container in the CI, we create more visibility on the state of the docker image. Any docker failures will result in a failed CI build. fixes #106. Dockerfile definition was using outdated definitions of packages.
svenrademakers
force-pushed
the
feature/docker_ci
branch
from
1d5d631
to
51f94d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using docker container in the CI, we create more visibility on the state of the docker image. Any docker failures will result in a failed CI build.
fixes #106. Dockerfile was using outdated definitions of packages.