Put match inner block in a `block` node #226

stsewd · 2023-07-11T19:06:55Z

This matches the other block statements (with, try, if, etc), all of them have a body field with a block node that contains the body of the statement.

tree-sitter-python/grammar.js

Lines 487 to 496 in 5a5455e

    
           _suite: $ => choice( 
        
             alias($._simple_statements, $.block), 
        
             seq($._indent, $.block), 
        
             alias($._newline, $.block) 
        
           ), 
        
           block: $ => seq( 
        
             repeat($._statement), 
        
             $._dedent 
        
           ),

This was also allowing

match 1: case 1: pass

Which is invalid, match blocks need an indentation

This matches the other block statements (with, try, if, etc), all of them have a body field with a block node that contains the body of the statement. https://github.com/tree-sitter/tree-sitter-python/blob/5a5455ef88ead370a9c7b93d8f55ea5a6b9127d7/grammar.js#L487-L496 This was also allowing ```python match 1: case 1: pass ``` Which is invalid, match blocks need an indentation

amaanq · 2023-07-12T11:30:14Z

Awesome

amaanq merged commit 538a532 into tree-sitter:master Jul 12, 2023
3 checks passed

stsewd deleted the match-block-node branch July 12, 2023 14:26

RayJameson mentioned this pull request Jul 12, 2023

Update to tree-sitter-python introduced bug nvim-treesitter/nvim-treesitter-context#298

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Put match inner block in a `block` node #226

Put match inner block in a `block` node #226

stsewd commented Jul 11, 2023

amaanq commented Jul 12, 2023

	_suite: $ => choice(
	alias($._simple_statements, $.block),
	seq($._indent, $.block),
	alias($._newline, $.block)
	),

	block: $ => seq(
	repeat($._statement),
	$._dedent
	),

Put match inner block in a block node #226

Put match inner block in a block node #226

Conversation

stsewd commented Jul 11, 2023

amaanq commented Jul 12, 2023

Put match inner block in a `block` node #226

Put match inner block in a `block` node #226