Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to sdkmanager and support latest SDK #992

Open
wants to merge 1 commit into
base: trusty-stable
Choose a base branch
from
Open

Migrate to sdkmanager and support latest SDK #992

wants to merge 1 commit into from

Conversation

partipan-dot
Copy link

@partipan-dot partipan-dot commented Aug 10, 2018

  • Migrate to sdkmanager command to install/update components
  • Updated initial Android SDK download to version 26.1.1
  • Support for Android SDK 28
  • Use new emulator (added to $PATH)

What is the problem that this PR is trying to fix?

The current version uses the deprecated android binary instead of sdkmanager and uses the old emulator. The highest supported SDK version is Android SDK 25.

What approach did you choose and why?

I updated the recipe to support the latest versions.

How can you make sure the change works as expected?

I tested it but please test it again. ;)

Would you like any additional feedback?

Is this change ok and if not what can be improved? Feedback is very welcome!

Fixes #965

- Migrate to `sdkmanager` command to install/update components
- Updated initial Android SDK download to version 26.1.1
- Support for Android SDK 28
- Use new emulator (added to $PATH)
@partipan-dot
Copy link
Author

The continuous-integration/travis-ci/pr is failing due to issues unrelated to this pull request.

Issues:

  • FC113: Resource declares deprecated use_inline_resources: community-cookbooks/iptables/providers/rule.rb:25 (Iptables?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant