Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14, support for Ruby back to 3.0.0 #15

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

mschwager
Copy link
Member

I tested this by changing the Dockerfile to use ubuntu:22.04 and running the example harness and confirming that coverage still works (it finds the crash). Ubuntu 22.04 currently uses clang 14.0.0, so we're able to say we've tested clang back a bit further now.

Originally I chose calling setup instead of start because I thought the performance characteristics would be better. setup appears to configure, but not fully enable coverage gathering, whereas start does both. Since Ruzzy doesn't need the builtin coverage information (we're adding our own hook), I thought performance would be better without the unnecessary builtin coverage hooks. But, you know what they say: make it work, make it correct, make it fast. I also didn't have any benchmarks to confirm this hypothesis, so who knows how this actually affected performance 🤷

@mschwager mschwager merged commit b88b214 into main Mar 26, 2024
5 checks passed
@mschwager mschwager deleted the mschwager-ruby-300 branch March 26, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant