You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: Adding assertions to verify error messages for invalid visibility values improves test coverage and ensures that the system behaves as expected when encountering errors.
type GameVisibility string
+const DefaultGameVisibility = private
Suggestion importance[1-10]: 8
Why: Setting a default value for GameVisibility enhances safety by ensuring consistent behavior when the visibility parameter is omitted, which is a significant improvement.
Why: Explicitly setting visibility in each test case enhances test independence and reliability, which is a good practice for maintaining robust tests.
Why: The suggestion to reconsider the default visibility value is valid as it prompts a review of whether 'openapi.Private' is the intended default. This could be crucial for ensuring the correct behavior of the application.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #906
新しく作ったAPIでは、ゲームの作成・編集において
visibility
がrequiredになっており、以前のAPIとの互換性が無くなってしまって、mainに入れられなかった。visibility
をoptionalにすることで、以前のAPIからも問題なくリクエストを送ることができる。visibility
が指定されなかった場合、private
として扱う