Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker composeのdepends_onを削除 #988

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Conversation

ikura-hamu
Copy link
Member

@ikura-hamu ikura-hamu commented Sep 21, 2024

User description

extendsを使ったときにdepends_onを使えなくなっていたので、削除した。


PR Type

configuration changes


Description

  • docker/base/compose.yamlファイルからdepends_onセクションを削除し、mariadbサービスの依存関係を解消しました。
  • extendsを使用する際にdepends_onが使えない問題に対処しました。

Changes walkthrough 📝

Relevant files
Configuration changes
compose.yaml
`depends_on`セクションの削除による依存関係の解消                                                     

docker/base/compose.yaml

  • depends_onセクションを削除
  • mariadbサービスの依存関係を削除
+0/-3     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

Copy link

github-actions bot commented Sep 21, 2024

PR Code Suggestions ✨

No code suggestions found for the PR.

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.09%. Comparing base (6714b34) to head (fc760df).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #988   +/-   ##
=======================================
  Coverage   55.09%   55.09%           
=======================================
  Files         159      159           
  Lines       11694    11694           
=======================================
  Hits         6443     6443           
  Misses       4829     4829           
  Partials      422      422           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ikura-hamu ikura-hamu merged commit 855c1e7 into main Sep 21, 2024
11 checks passed
@ikura-hamu ikura-hamu deleted the fix/compose_depends_on branch September 21, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant