Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change pr-agent config #12

Closed
wants to merge 1 commit into from
Closed

change pr-agent config #12

wants to merge 1 commit into from

Conversation

kaitoyama
Copy link
Contributor

No description provided.

@kaitoyama kaitoyama self-assigned this Jun 27, 2024
Copy link

Title

change pr-agent config


PR Type

configuration changes, enhancement


Description

  • pull_request イベントに opened タイプを追加しました。
  • issue_comment イベントのタイプをリスト形式に変更しました。
  • pr_agent_job の実行条件に draft == false を追加しました。
  • 環境変数 PR_DESCRIPTION.ADD_ORIGINAL_USER_DESCRIPTION の値を false に変更しました。

Changes walkthrough 📝

Relevant files
Configuration changes
pr-agent.yml
PRエージェント設定ファイルの更新                                                                               

.github/workflows/pr-agent.yml

  • pull_request イベントに opened タイプを追加
  • issue_comment イベントのタイプをリスト形式に変更
  • pr_agent_job の条件に draft == false を追加
  • 環境変数 PR_DESCRIPTION.ADD_ORIGINAL_USER_DESCRIPTION の値を false に変更
  • +16/-16 

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review [1-5] 2
    🧪 Relevant tests No
    🔒 Security concerns No
    ⚡ Key issues to review Configuration Consistency:
    The changes in event types for pull_request and issue_comment triggers are expanded to include more types. Ensure that this aligns with the intended workflow triggers and does not lead to unintended executions.
    Conditional Logic Adjustment:
    The condition for pr_agent_job has been modified to exclude drafts explicitly (github.event.pull_request.draft == false). Verify that this logic correctly reflects the desired behavior in all scenarios.

    @kaitoyama kaitoyama closed this Jun 27, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant