Merge pull request #368 from tpill90/RenameBigChunks

tpill90 · Jul 13, 2024 · 1a1d7e0 · 1a1d7e0
2 parents e95c558 + 38b372d
commit 1a1d7e0
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/SteamPrefill/CliCommands/Benchmark/BenchmarkModels.cs b/SteamPrefill/CliCommands/Benchmark/BenchmarkModels.cs
@@ -57,7 +57,7 @@ public void PrintSummary(IAnsiConsole ansiConsole)
                        .AddRow(White(Underline("Benchmark workload summary")))
                        .AddRow(BuildSummaryTable())
                        // Request distribution
-                       .AddRow(White(Underline("Request size distribution")))
+                       .AddRow(White(Underline("Chunk size distribution")))
                        .AddEmptyRow()
                        .AddRow(BuildRequestSizeChart());
 
@@ -94,7 +94,7 @@ private Table BuildSummaryTable()
         }
 
         /// <summary>
-        /// Generates a bar chart of request size distribution
+        /// Generates a bar chart of chunk size distribution
         /// </summary>
         private BarChart BuildRequestSizeChart()
         {
@@ -237,7 +237,7 @@ public override string ToString()
     [Intellenum(typeof(string))]
     public sealed partial class PresetWorkload
     {
-        public static readonly PresetWorkload BigChunks = new PresetWorkload("1085660");
+        public static readonly PresetWorkload LargeChunks = new PresetWorkload("1085660");
         public static readonly PresetWorkload SmallChunks = new PresetWorkload("570");
     }
 }
diff --git a/SteamPrefill/CliCommands/Benchmark/BenchmarkSetupCommand.cs b/SteamPrefill/CliCommands/Benchmark/BenchmarkSetupCommand.cs
@@ -21,7 +21,7 @@ public class BenchmarkSetupCommand : ICommand
         public bool? NoAnsiEscapeSequences { get; init; }
 
         [CommandOption("preset",
-            Description = "Sets up a benchmark with one or more preset workloads, with differing performance characteristics. Can be SmallChunks/BigChunks",
+            Description = "Sets up a benchmark with one or more preset workloads, with differing performance characteristics. Can be SmallChunks/LargeChunks",
             Converter = typeof(PresetWorkloadConverter),
             Validators = new[] { typeof(PresetWorkloadValidator) })]
         public IReadOnlyList<PresetWorkload> Presets { get; init; } = new List<PresetWorkload> { };

diff --git a/SteamPrefill/CliCommands/Converters.cs b/SteamPrefill/CliCommands/Converters.cs
@@ -69,7 +69,7 @@ public override BindingValidationError Validate(PresetWorkload[] value)
             }
 
             AnsiConsole.MarkupLine(Red($"A preset must be specified when using {LightYellow("--preset")}"));
-            AnsiConsole.Markup(Red($"Valid presets include : {LightYellow("SmallChunks/BigChunks")}"));
+            AnsiConsole.Markup(Red($"Valid presets include : {LightYellow("SmallChunks/LargeChunks")}"));
             throw new CommandException(".", 1, true);
         }
     }
@@ -87,7 +87,7 @@ public override PresetWorkload Convert(string rawValue)
             }
 
             AnsiConsole.MarkupLine(Red($"{White(rawValue)} is not a valid preset"));
-            AnsiConsole.Markup(Red($"Valid presets include : {LightYellow("SmallChunks/BigChunks")}"));
+            AnsiConsole.Markup(Red($"Valid presets include : {LightYellow("SmallChunks/LargeChunks")}"));
             throw new CommandException(".", 1, true);
         }
     }

diff --git a/SteamPrefill/Properties/launchSettings.json b/SteamPrefill/Properties/launchSettings.json
@@ -22,7 +22,7 @@
     },
     "Benchmark - Setup - Preset": {
       "commandName": "Project",
-      "commandLineArgs": "benchmark setup --preset SmallChunks"
+      "commandLineArgs": "benchmark setup --preset LargeChunks"
     },
     "Benchmark - Setup - All": {
       "commandName": "Project",