Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix create package ci #47

Merged
merged 4 commits into from
Jun 20, 2024
Merged

ci: fix create package ci #47

merged 4 commits into from
Jun 20, 2024

Conversation

Autumn60
Copy link
Contributor

@Autumn60 Autumn60 commented Jun 20, 2024 •
edited by sasakisasaki
Loading

PR Type

  • Bug Fix

Related Links

Description

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Autumn60 and others added 4 commits June 6, 2024 11:47
add create-ros2-package workflow and template files
11c5b21 
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
rename template files
90e058b 
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
fix create_pkg ci
43c6924 
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
@Autumn60
Merge branch 'main' into ci/fix_create_pkg_ci
66f8d62
@Autumn60 Autumn60 enabled auto-merge (squash) June 20, 2024 00:21
sasakisasaki
sasakisasaki approved these changes Jun 20, 2024
View reviewed changes
Copy link

@sasakisasaki sasakisasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Autumn60 Autumn60 merged commit b3432fa into main Jun 20, 2024
8 of 9 checks passed
@Autumn60 Autumn60 deleted the ci/fix_create_pkg_ci branch June 20, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasakisasaki sasakisasaki sasakisasaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Autumn60 @sasakisasaki