Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: exclude build and example folders from coverage #199

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Sep 25, 2024

PR Type

  • Improvement

Related Links

Description

This PR removes the build and nebula_examples folders from code coverage statistics.
The build folder contains the code-generation results from nebula_msgs etc. and should not be included (also, it's 9000 lines 🤯).
The nebula_examples folder is not part of the main functionality of the software and thus, coverage is not important.

With this PR, coverage goes from 10% to 28%:
image

⚠️ Dummy changes in all modules were necessary to trigger the coverage report, these have since been reverted.

Review Procedure

Compare coverage results from before and after given the links above and confirm that

  • the directories are removed
  • all other relevant directories are present and correct

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex self-assigned this Sep 25, 2024
@mojomex mojomex force-pushed the chore/exclude-directories-from-codecov branch 2 times, most recently from f90be24 to bbf0f27 Compare September 26, 2024 06:00
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.09%. Comparing base (18af521) to head (1b8105e).
Report is 46 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #199       +/-   ##
===========================================
+ Coverage   10.09%   28.09%   +17.99%     
===========================================
  Files         251      106      -145     
  Lines       19468     9223    -10245     
  Branches     1225     2205      +980     
===========================================
+ Hits         1966     2591      +625     
+ Misses      17502     6580    -10922     
- Partials        0       52       +52     
Flag Coverage Δ
differential 28.09% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mojomex mojomex force-pushed the chore/exclude-directories-from-codecov branch from 1b8105e to aee5e8c Compare September 26, 2024 06:53
@mojomex
Copy link
Collaborator Author

mojomex commented Sep 26, 2024

Cannot meaningfully review other than re-running CI. Codecov works, so I'll merge this.

@mojomex mojomex merged commit c2b0414 into tier4:main Sep 26, 2024
12 checks passed
@mojomex mojomex deleted the chore/exclude-directories-from-codecov branch September 26, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant