fix(at128): allow negative values in points' elevation fields
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojomex
force-pushed
the
at128-fix-elevation
branch
from
8b19e03
to
cc5aa7c
Compare
mojomex
force-pushed
the
at128-fix-elevation
branch
from
cc5aa7c
to
a1e184e
Compare
|
@knzo25 Thank you for the reminder, done. 👍 |
|
@knzo25 As discussed internally, since this is a small 'hotfix'-style change, this is fine to merge into main. |
…nicely with visualization
mojomex
force-pushed
the
at128-fix-elevation
branch
from
a1e184e
to
7245521
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
==========================================
- Coverage 29.65% 25.78% -3.88%
==========================================
Files 99 99
Lines 8760 8747 -13
Branches 2173 2146 -27
==========================================
- Hits 2598 2255 -343
+ Misses 6116 6106 -10
- Partials 46 386 +340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Description
Only AT128 normalized its points'
elevationfield to [0, 2pi) while other sensors allowed negativeelevationvalues. While the normalization is done on azimuth as well and thus, for consistency sake, would be nice on the elevation field, too, this causes visualizations to look ugly when coloring byelevation.Anyway, trigonometry functions won't care about this change as they are periodic, and given that all other sensors are not normalizing elevation, it is safe to assume this doesn't impact downstream modules.
Review Procedure
Confirm the
elevationfield looks correct. Code review.Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks