Skip to content

Commit

Permalink
.github: Move review to GitHub pull request
Browse files Browse the repository at this point in the history
Since edk2 and edk2-platform moved reviews to GitHub pull requests,
we follow the same process and move edk2-redfish-clients reviews to
GitHub pull requests.

- Add CODEOWNERS to automatically attach reviewer when pull request
is created.
- Add pull request template to remind developer to add required
information in pull request description.
- Update README.md.

Signed-off-by: Nickle Wang <nicklew@nvidia.com>
  • Loading branch information
nicklela committed Jul 13, 2024
1 parent e23688c commit 00062f6
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# EDK Redfish Client Maintainers
* @changab @igorkulchytskyy @nicklela
9 changes: 9 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Description

<_Include a description of the change and why this change was made._>

<_Delete lines in \<\> tags before creating the PR._>

## How This Was Tested

<_Describe the test(s) that were run to verify the changes._>
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@ See [Maintainers.txt](Maintainers.txt).

# Contributing

The patch review process would be the same as edk2, and adding prefix **[edk2-redfish-client]**
specifically for the patches against edk2-redfish-client repository. For more details, please
see [CONTRIBUTING.md](CONTRIBUTING.md).
The review process would be the same as [edk2](https://github.com/tianocore/edk2/tree/master?tab=readme-ov-file#code-contributions).
For more details, please see [CONTRIBUTING.md](CONTRIBUTING.md).

# How to build (Ubuntu Environment)
## Prerequisite
Expand Down

0 comments on commit 00062f6

Please sign in to comment.